feat: use junction instead of symlink for Windows #23

ldkv · 2025-11-27T19:40:48Z

This PR replaces symlink with Windows junction on Windows OS.

It allows to link a directory on Windows without admin privileges or Developer Mode. Should address #5

Note

Adds cross-platform link utilities that create Windows junctions as needed and updates CLI, project logic, and tests to recognize them.

Core Utilities:
- Add src/uvlink/path_utils.py with is_windows, is_link_or_junction, path_exists, create_windows_junction, and create_symlink (fallback to junctions on Windows).
CLI (src/uvlink/cli.py):
- Refactor link to use path_exists for existence checks and create_symlink for creation; streamline prompts and creation flow.
Project (src/uvlink/project.py):
- Update rm_rf to remove links via is_link_or_junction.
- Compute is_linked using is_link_or_junction in Projects.get_list.
Tests:
- Accept junctions in link assertions (is_symlink() or is_junction()), add non-existence check for junctions in dry-run, and use create_symlink in project path resolution tests.
- Simplify unlink with unlink(missing_ok=True).

^{Written by Cursor Bugbot for commit 4b04326. This will update automatically on new commits. Configure here.}

c0rychu · 2025-11-28T04:09:55Z

Yeah, splitting them into two would be better.

Also, could you change the target branch to c0rychu:support-windows, which makes it easier for me.

c0rychu

Some comments

src/uvlink/path_utils.py

tests/test_cli.py

tests/test_project.py

ldkv · 2025-11-28T13:42:15Z

Yeah, splitting them into two would be better.

Also, could you change the target branch to c0rychu:support-windows, which makes it easier for me.

Done. I only keep the junction update for this PR. Will add the tests adaptation in another.

c0rychu

@ldkv thank you so much for your work!

Sorry for being a little picky and opinionated here, but these are my comments/suggested changes.
If the Windows-only test that mocks the except OSError requires too much work, we can merge this PR first and create that test later as long as you verify that it's working on your Windows machine.
It would be nice to add docstrings with Google style, but I can also ask codex-cli to do that afterwards, so either way, don't worry about it.

src/uvlink/path_utils.py

tests/test_project.py

src/uvlink/path_utils.py

src/uvlink/cli.py

tests/test_project.py

cursor

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

src/uvlink/path_utils.py

src/uvlink/project.py

c0rychu

Address comments from cursor bugbot

src/uvlink/path_utils.py

src/uvlink/project.py

src/uvlink/path_utils.py

ldkv · 2025-11-28T19:14:30Z

@ldkv thank you so much for your work!

1. Sorry for being a little picky and opinionated here, but these are my comments/suggested changes.

2. If the Windows-only test that mocks the `except OSError` requires too much work, we can merge this PR first and create that test later as long as you verify that it's working on your Windows machine.

3. It would be nice to add docstrings with Google style, but I can also ask `codex-cli` to do that afterwards, so either way, don't worry about it.

Hey no worry, your product your call. Your comments are good too. I will let you update the docstrings as you like, personally I find the type annotations suffice.

I will add a test for the OSError in the 2nd PR.

c0rychu

Great!

c0rychu · 2025-11-28T19:33:22Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no bugs!

c0rychu reviewed Nov 28, 2025

View reviewed changes

src/uvlink/path_utils.py Outdated Show resolved Hide resolved

src/uvlink/path_utils.py Outdated Show resolved Hide resolved

tests/test_cli.py Outdated Show resolved Hide resolved

c0rychu added the os:Windows label Nov 28, 2025

c0rychu reviewed Nov 28, 2025

View reviewed changes

tests/test_project.py Show resolved Hide resolved

feat: use junction instead of symlink for Windows

804523d

ldkv force-pushed the windows-junction branch from 5d11532 to 804523d Compare November 28, 2025 13:40

ldkv changed the base branch from main to support-windows November 28, 2025 13:40

ldkv mentioned this pull request Nov 28, 2025

fix: adapt tests for Windows #24

Merged

c0rychu requested changes Nov 28, 2025

View reviewed changes

c0rychu added 6 commits November 28, 2025 09:34

WIP: Update src/uvlink/path_utils.py

11eaa4e

WIP: Update src/uvlink/path_utils.py

fca904a

WIP: Update src/uvlink/path_utils.py

637bc79

WIP: Update tests/test_project.py

70814de

WIP: Update src/uvlink/path_utils.py

e29a3ce

WIP: Update src/uvlink/cli.py

1ad428e

c0rychu requested changes Nov 28, 2025

View reviewed changes

src/uvlink/cli.py Outdated Show resolved Hide resolved

WIP: Update src/uvlink/cli.py

fbf0a4e

c0rychu reviewed Nov 28, 2025

View reviewed changes

tests/test_project.py Show resolved Hide resolved

WIP: Apply suggestion from @c0rychu

e74531b

cursor bot reviewed Nov 28, 2025

View reviewed changes

src/uvlink/path_utils.py Outdated Show resolved Hide resolved

src/uvlink/project.py Outdated Show resolved Hide resolved

c0rychu reviewed Nov 28, 2025

View reviewed changes

src/uvlink/path_utils.py Outdated Show resolved Hide resolved

src/uvlink/project.py Outdated Show resolved Hide resolved

c0rychu added 2 commits November 28, 2025 10:06

WIP: address cursor bugbot comments

dd6bb6e

WIP: address cursor bugbot comments

abb6e0f

cursor bot reviewed Nov 28, 2025

View reviewed changes

src/uvlink/path_utils.py Outdated Show resolved Hide resolved

c0rychu marked this pull request as draft November 28, 2025 16:27

WIP: use Windows path format

4b04326

ldkv requested a review from c0rychu November 28, 2025 19:11

c0rychu reviewed Nov 28, 2025

View reviewed changes

c0rychu marked this pull request as ready for review November 28, 2025 19:31

cursor bot reviewed Nov 28, 2025

View reviewed changes

c0rychu merged commit 9d73d95 into c0rychu:support-windows Nov 28, 2025
8 of 11 checks passed

ldkv deleted the windows-junction branch November 28, 2025 21:56

c0rychu mentioned this pull request Nov 28, 2025

OSError on windows: uvlink need to run with admin privileges #5

Closed

feat: use junction instead of symlink for Windows #23

feat: use junction instead of symlink for Windows #23

Uh oh!

Conversation

ldkv commented Nov 27, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

c0rychu commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

c0rychu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ldkv commented Nov 28, 2025

Uh oh!

c0rychu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

This PR is being reviewed by Cursor Bugbot

Uh oh!

Uh oh!

Uh oh!

c0rychu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ldkv commented Nov 28, 2025

Uh oh!

c0rychu left a comment

Choose a reason for hiding this comment

Uh oh!

c0rychu commented Nov 28, 2025

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

✅ Bugbot reviewed your changes and found no bugs!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ldkv commented Nov 27, 2025 •

edited by cursor bot

Loading

c0rychu commented Nov 28, 2025 •

edited

Loading